Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nano Subsystem Init Error #5119

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Dec 4, 2023

About the pull request

This PR fixes an unintended change made in #4940 where the flag for the nano subsystem was changed. If Initialize was used instead of New this change would be correct, but using New is intentional.

Explain why it's good for the game

Fixes: Initialized Nano UI subsystem with errors within 0 seconds! and [20:19:57]WARNING: Nano UI subsystem does not implement Initialize() or it returns ..(). If the former is true, the SS_NO_INIT flag should be set for this subsystem.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 Drathek
fix: Fix some errors regarding the nano subystem
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 4, 2023
@harryob harryob added this pull request to the merge queue Dec 6, 2023
Merged via the queue into cmss13-devs:master with commit cc21f9b Dec 6, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 6, 2023
@Drulikar Drulikar deleted the Fix_Nanoui_Initialization branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants